lkml.org 
[lkml]   [2003]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] missing io_apic.h inclusions
Linux Kernel Mailing List wrote:
> diff -Nru a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c
> --- a/arch/i386/kernel/acpi/boot.c Thu Aug 21 02:12:34 2003
> +++ b/arch/i386/kernel/acpi/boot.c Thu Aug 21 02:12:34 2003
> @@ -34,6 +34,7 @@
> #if defined (CONFIG_X86_LOCAL_APIC)
> #include <mach_apic.h>
> #include <mach_mpparse.h>
> +#include <asm/io_apic.h>
> #endif
>
> #define PREFIX "ACPI: "
> diff -Nru a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
> --- a/arch/i386/kernel/setup.c Thu Aug 21 02:12:34 2003
> +++ b/arch/i386/kernel/setup.c Thu Aug 21 02:12:34 2003
> @@ -43,6 +43,7 @@
> #include <asm/setup.h>
> #include <asm/arch_hooks.h>
> #include <asm/sections.h>
> +#include <asm/io_apic.h>
> #include "setup_arch_pre.h"
> #include "mach_resources.h"


Well, the first change looks pretty wrong just given the config option.
And, too, this was the false "build fix". The correct build fix was
committed, and this patch was not needed at all. I'll grant that the
patch to setup.c does make sense, though, even if it's not strictly needed.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.031 / U:5.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site