lkml.org 
[lkml]   [2003]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.6.0-test3 zoran driver update
Ronald Bultje <rbultje@ronald.bitfreak.net> :
[...]

- {adv7170/adv7175/bt819/saa7110/saa7185}_detect_client()
for each of these functions, two error exit path leak on locally allocated
variable "channel".

- {adv7170/adv7175/bt819/saa7111/saa7185}_write_block()
The code duplication could surely be avoided.

- always put a blank line between variables declaration and code pleae

- find_zr36057():
what about replacing pci_find_device() by the modern pci insertion/removal
api (which has been standing there for ~3 years)

- pci_enable_device() in find_zr36057() isn't balanced by pci_disable_device()
in zoran_release()

- +irqreturn_t
+zoran_irq (int irq,
[...]
+ for (i = 0; i < 4; i++) {
+ if (zr->
+ stat_com[i] &
+ 1)
+ sv[i] =
+ '1';
+ }

Post-modernism ?


It looks interesting.

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.051 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site