[lkml]   [2003]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Dumb question: BKL on reboot ?
Hannes Reinecke <> wrote:
> Hiya,
> I've got a dumb question: Why is the BKL held on entering sys_reboot()
> in kernel/sys.c:405 ?

Probably for no good reason.

> It is getting especially interesting on SMP, when one cpu is entering
> sys_reboot, acquires the BKL and then waits (via machine_restart) for
> all other cpus to shut down. If any of the other cpus is executing a
> task which also needs the BKL, we have a nice deadlock.
> We've seen this here on 2-way s390, where the other cpu tried to execute
> kupdated() (what did it try that for? Anyway...), which of course
> resulted in a deadlock.

I guess that dropping the BKL around the machine_restart() call would be an
appropriate 2.4 fix.

Where exactly does the rebooting CPU get stuck in machine_restart()? If
someone has done lock_kernel() with local interrupts disabled then yes,
it'll deadlock. But that's unlikely? Confused.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:47    [W:0.075 / U:1.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site