lkml.org 
[lkml]   [2003]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Linux 2.4.22-pre10-ac1
On Sat, Aug 02, 2003 at 11:23:53AM +0200, Marcel Holtmann wrote:
> Hi Manuel,
>
> > > ccache gcc -D__KERNEL__ -I/home/barryn/lsx/kernels/2.4/build/linux-2.4.22-pre10-ac1/include -Wall -Wstrict-prototypes -Wno-trigraphs -Os -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -DMODVERSIONS -include /home/barryn/lsx/kernels/2.4/build/linux-2.4.22-pre10-ac1/include/linux/modversions.h -nostdinc -iwithprefix include -DKBUILD_BASENAME=firmware_class -DEXPORT_SYMTAB -c firmware_class.c
> > > firmware_class.c: In function `call_helper':
> > > firmware_class.c:78: error: `hotplug_path' undeclared (first use in this function)
> > > firmware_class.c:78: error: (Each undeclared identifier is reported only once
> > > firmware_class.c:78: error: for each function it appears in.)
> > > make[1]: *** [firmware_class.o] Error 1
> > > make[1]: Leaving directory `/home/barryn/lsx/kernels/2.4/build/linux-2.4.22-pre10-ac1/lib'
> > > make: *** [_mod_lib] Error 2
> > [snip]
> > > # CONFIG_HOTPLUG is not set
> >
> > CONFIG_HOTPLUG needs to be enabled, attached patch to make it explicit:
>
> your patch didn't fix the problem, because it will be the same if some
> internal driver needs request_firmware() and CONFIG_HOTPLUG is not set.
> The call_helper() funtcion needs to be put into #idef's.

request_firmware() needs hotplug to do anything useful, without
hotplug it doesn't make any sense. It is useless.

The patch may not be it, but, IMHO, the way to go is making
request_firmware() explicitly depend on hotplug, because it does depend
on it. Suggestions are welcomed.

Regards

Manuel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.060 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site