Messages in this thread | | | Date | Sat, 2 Aug 2003 20:12:39 -0600 | From | Erik Andersen <> | Subject | Re: [PATCH] ide-disk.c rev 1.13 killed CONFIG_IDEDISK_STROKE |
| |
On Sun Aug 03, 2003 at 03:26:59AM +0200, Andries Brouwer wrote: > On Sat, Aug 02, 2003 at 05:34:38PM -0600, Erik Andersen wrote: > > > I have rewritten the init_idedisk_capacity() function and taught > > it to behave itself. It is now much cleaner IMHO > > Yes, nice cleanup.
Thanks. :-)
> Some comments for later - the patch can be applied as it is: > > The assignment > drive->select.b.lba = 0/1; > is done in the first half of init_idedisk_capacity(). > I don't think the presence or disabling of HPA has any effect > on b.lba, so there should not be such assignments in the > second, HPA, half.
Yes, you are right. This is garbage leftover from the previous implementation. It should not change anything, but that would be a nice additional cleanup.
> My standard muttering: id->... should not be modified.
Agreed, but that is best left for another patch, since I did not want to walk through the whole ide stack checking for things that depends on this behavior. Hopefully nothing, but you never know.
> In my source I test drive->head * drive->sect for being nonzero > before dividing.
That would also be a nice additional cleanup.
-Erik
-- Erik B. Andersen http://codepoet-consulting.com/ --This message was written using 73% post-consumer electrons-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |