lkml.org 
[lkml]   [2003]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.0-test2-mm2
Dave Jones <davej@codemonkey.org.uk> wrote:
>
> On Wed, Jul 30, 2003 at 10:38:10PM -0700, Andrew Morton wrote:
>
> > +intel-agp-oops-fix.patch
> > another oops fix
>
> patch is correct, but I'm wondering what managed to iterate that
> far, do you have any hw info on the box that oopsed ?

Nah, that patch is bogus:

.subdevice = PCI_ANY_ID,
},
- { }
+ { 0, },

These two things are equivalent: it is a no-op.

The bug was actually the __devinitdata problem.

> > +pci_device_id-devinitdata.patch
> > Move lots of PCI device_id tables out of __initdata
>
> How embarressing. Russell King noticed a similar problem
> in agpgart a while back, and I overlooked the adjacent struct.
> Likewise, I goofed in cpufreq. Oops. Thanks for fixing them up.

Greg did a tree-wide sweep and removed __devinitdata and __initdata from a
large number of pci_device_id tables. Linus merged that yesterday.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.128 / U:4.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site