Messages in this thread | | | Subject | Re: [PATCH] RFC: kills consistent_dma_mask | From | Krzysztof Halasa <> | Date | 19 Aug 2003 11:49:28 +0200 |
| |
Jes Sorensen <jes@wildopensource.com> writes:
> Bzzzt, *wrong*! Take a look at drivers/scsi/aic7xxx/aic7xxx_osm_pci.c, > if you look at the code you will notice that the hardware does support > different masks for consistent vs dynamic allocations (32 bit for > consistent vs 39 or 64 bit for dynamic).
The hardware, maybe.
> However make a note that the > driver uses the current interface incorrectly and thinks that > pci_set_dma_mask() actually applies to pci_alloc_consistent, which is > something it never did.
No, it nearly always does. Looks at the actual pci_alloc_consistent on, say, i386.
Will it be ok if I fix the consistent allocs to use consistent_dma_mask (some drivers will need a fix on i386 etc.)? -- Krzysztof Halasa Network Administrator - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |