lkml.org 
[lkml]   [2003]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] EISA bus update
On Tue, Aug 19, 2003 at 02:48:24PM +0200, Marc Zyngier wrote:
> +static void virtual_eisa_release (struct device *dev)
> +{
> + /* nothing really to do here */
> +}

Um, no. That's not correct. Don't just paper over valid warning
messages in the kernel by adding functions that do not do anything.

Marc, why do you think that you do not need to do anything in this
function? Don't you need to handle the fact that your code could be
removed before the release function is called?

Linus, please do not apply this just yet.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.093 / U:1.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site