lkml.org 
[lkml]   [2003]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] fix cu3088 group write
    Hi Linus,

    The current cu3088 ccwgroup write code overwrite the last char of the
    given arguments. This patch fixes the problem :

    --- linux-2.6.0-test3-bk6.orig/drivers/s390/net/cu3088.c 2003-08-19 16:19:32.000000000 +0000
    +++ linux-2.6.0-test3-bk6/drivers/s390/net/cu3088.c 2003-08-19 16:22:46.000000000 +0000
    @@ -64,7 +64,7 @@
    group_write(struct device_driver *drv, const char *buf, size_t count)
    {
    const char *start, *end;
    - char bus_ids[2][BUS_ID_SIZE], *argv[2];
    + char bus_ids[2][BUS_ID_SIZE+1], *argv[2];
    int i;
    int ret;
    struct ccwgroup_driver *cdrv;
    @@ -79,7 +79,7 @@

    if (!(end = strchr(start, delim[i])))
    return count;
    - len = min_t(ptrdiff_t, BUS_ID_SIZE, end - start);
    + len = min_t(ptrdiff_t, BUS_ID_SIZE, end - start)+1;
    strlcpy (bus_ids[i], start, len);
    argv[i] = bus_ids[i];
    start = end + 1;

    memcpy is not an option since the string will be used with strncmp with
    a length > BUS_ID_SIZE.
    Please apply.

    --
    Guillaume Morin <guillaume@morinfr.org>

    Build a man a fire, and he'll be warm for a day. Set a man on fire,
    and he'll be warm for the rest of his life. (Terry Pratchett)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:47    [W:0.043 / U:0.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site