Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] use simple_strtoul for unsigned kernel parameters | Date | Mon, 18 Aug 2003 20:13:33 +1000 |
| |
In message <20030818004618.GA5094@mail.jlokier.co.uk> you write: > The largest "unsigned int" value doesn't fit in a "long", on many machines. > So we should use simple_strtoul, not simple_strtol, to decode these values.
Half right. The second part is fine, the first part is redundant AFAICT.
Rusty.
> Enjoy, > -- Jamie > > --- orig-2.5.75/kernel/params.c 2003-07-08 21:44:26.000000000 +0100 > +++ laptop-2.5.75/kernel/params.c 2003-08-17 03:17:40.116594605 +0100 > @@ -165,9 +165,9 @@ > } > > STANDARD_PARAM_DEF(short, short, "%hi", long, simple_strtol); > -STANDARD_PARAM_DEF(ushort, unsigned short, "%hu", long, simple_strtol); > +STANDARD_PARAM_DEF(ushort, unsigned short, "%hu", unsigned long, simple_strtoul); > STANDARD_PARAM_DEF(int, int, "%i", long, simple_strtol); > -STANDARD_PARAM_DEF(uint, unsigned int, "%u", long, simple_strtol); > +STANDARD_PARAM_DEF(uint, unsigned int, "%u", unsigned long, simple_strtoul); > STANDARD_PARAM_DEF(long, long, "%li", long, simple_strtol); > STANDARD_PARAM_DEF(ulong, unsigned long, "%lu", unsigned long, simple_strtoul); >
-- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |