lkml.org 
[lkml]   [2003]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Fix up riscom8 driver to use work queues instead of task queueing.
On Mon, Aug 18, 2003 at 04:59:53PM +0000, Linux Kernel Mailing List wrote:
> @@ -425,7 +414,7 @@
>
> *tty->flip.char_buf_ptr++ = ch;
> tty->flip.count++;
> - queue_task(&tty->flip.tqueue, &tq_timer);
> + schedule_delayed_work(&tty->flip.work, 1);
> }
>
> static inline void rc_receive(struct riscom_board const * bp)
> @@ -456,7 +445,7 @@
> *tty->flip.flag_buf_ptr++ = 0;
> tty->flip.count++;
> }
> - queue_task(&tty->flip.tqueue, &tq_timer);
> + schedule_delayed_work(&tty->flip.work, 1);
> }
>
> static inline void rc_transmit(struct riscom_board const * bp)

Should we just make schedule_delayed_work(foo, 1) the default for a
schedule_work() call?

I'm seeing this construct pop up more and more... and would rather have
it fixed at the source, not in every driver.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.057 / U:1.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site