Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] use simple_strtoul for unsigned kernel parameters | Date | Tue, 19 Aug 2003 01:32:59 +1000 |
| |
In message <20030818120955.GB7147@mail.jlokier.co.uk> you write: > Rusty Russell wrote: > > In message <20030818004618.GA5094@mail.jlokier.co.uk> you write: > > > The largest "unsigned int" value doesn't fit in a "long", on many machines. > > > So we should use simple_strtoul, not simple_strtol, to decode these values. > > > > Half right. The second part is fine, the first part is redundant > > Do you mean the first part of the comment or the first part of the patch? > > Assuming you mean the patch, you're right: the unsigned short case > doesn't need to be changed. It should be anyway because it is just > the right thing to do.
<shrug>. Linus took the patch. If you think it's the Right Thing, great.
Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |