lkml.org 
[lkml]   [2003]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] thread coredump oops fix
From
Date
Hi,

If ->group_leader of current thread already was exiting,
group_leader's ->mm is NULL in fill_psinfo(). Then I got Oops.

This uses current->mm instead of ->group_leader->mm to dump args.


fs/binfmt_elf.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)

diff -puN fs/binfmt_elf.c~thread_coredump-fix fs/binfmt_elf.c
--- linux-2.6.0-test3/fs/binfmt_elf.c~thread_coredump-fix 2003-08-15 05:41:44.000000000 +0900
+++ linux-2.6.0-test3-hirofumi/fs/binfmt_elf.c 2003-08-15 07:09:45.000000000 +0900
@@ -1084,18 +1084,19 @@ static void fill_prstatus(struct elf_prs
jiffies_to_timeval(p->cstime, &prstatus->pr_cstime);
}

-static void fill_psinfo(struct elf_prpsinfo *psinfo, struct task_struct *p)
+static void fill_psinfo(struct elf_prpsinfo *psinfo, struct task_struct *p,
+ struct mm_struct *mm)
{
int i, len;

/* first copy the parameters from user space */
memset(psinfo, 0, sizeof(struct elf_prpsinfo));

- len = p->mm->arg_end - p->mm->arg_start;
+ len = mm->arg_end - mm->arg_start;
if (len >= ELF_PRARGSZ)
len = ELF_PRARGSZ-1;
copy_from_user(&psinfo->pr_psargs,
- (const char *)p->mm->arg_start, len);
+ (const char *)mm->arg_start, len);
for(i = 0; i < len; i++)
if (psinfo->pr_psargs[i] == 0)
psinfo->pr_psargs[i] = ' ';
@@ -1280,7 +1281,7 @@ static int elf_core_dump(long signr, str

fill_note(notes +0, "CORE", NT_PRSTATUS, sizeof(*prstatus), prstatus);

- fill_psinfo(psinfo, current->group_leader);
+ fill_psinfo(psinfo, current->group_leader, current->mm);
fill_note(notes +1, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo);

fill_note(notes +2, "CORE", NT_TASKSTRUCT, sizeof(*current), current);
_

--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.026 / U:2.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site