Messages in this thread | | | Subject | Re: [PATCH] ide: limit drive capacity to 137GB if host doesn't support LBA48 | From | Alan Cox <> | Date | 14 Aug 2003 09:53:28 +0100 |
| |
On Iau, 2003-08-14 at 02:24, Bartlomiej Zolnierkiewicz wrote: > hwif->rqsize = old_hwif.rqsize; > - hwif->addressing = old_hwif.addressing; > + hwif->no_lba48 = old_hwif.no_lba48;
This change is a bad idea. Its called "addressing" because that is what it is about (see SATA and ATA specs). In future SATA addressing becomes a 0,1,2 value because 48bits isnt enough, it may get more forms beyond that.
Might be worth defining ADDR_LBA48, ADDR_LBA28 etc to make it clearer, but really people shouldnt be randomly hacking IDE code without having read the specifications.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |