lkml.org 
[lkml]   [2003]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] call drv->shutdown at rmmod
On Thu, Aug 14, 2003 at 01:06:45AM -0600, Eric W. Biederman wrote:
>
> At the kexec BOF at OSDL there was some discussion on calling the
> device shutdown method at module remove time, in addition to calling
> it during reboot. The driver was the observation that the primary
> source of problems in booting linux from linux are drivers with bad
> or missing drv->shutdown() routines. The hope is this will increase
> the testing so people can get it right and kexec can become more
> useful. In addition to making normal reboots more reliable.
>
> The following patch is an implementation of that idea it calls drv->shutdown()
> before calling drv->remove(). If drv->shutdown() is implemented.

Sounds really confusing. And having shutdown maybe called before remove
but not always sounds like a design mistake.

Why do we have shutdown at all? Can't we just call ->remove on shutdown
so the device always get's into proper unitialized state on shutdown, too?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [from the cache]
©2003-2011 Jasper Spaans