lkml.org 
[lkml]   [2003]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: C99 Initialisers
    On Wed, Aug 13, 2003 at 07:50:09PM +0200, Sam Ravnborg wrote:
    > On Wed, Aug 13, 2003 at 10:31:51AM -0700, Greg KH wrote:
    > >
    > > How about this patch? If you like it I'll add the pci.h change to the
    > > tree and let you take the tg3.c part.
    > >
    > > + { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5700) },
    > Why not without the extra {}'s so something like this:

    Take a moment to think about this (as it is currently):

    #define CB_ID(vend,dev,type) \
    { \
    .vendor = vend, \
    .device = dev, \
    .subvendor = PCI_ANY_ID, \
    .subdevice = PCI_ANY_ID, \
    .class = PCI_CLASS_BRIDGE_CARDBUS << 8, \
    .class_mask = ~0, \
    .driver_data = CARDBUS_TYPE_##type, \
    }

    vs:

    #define CB_ID(vend,dev,type) \
    { \
    PCI_DEVICE(vend,dev), \
    .class = PCI_CLASS_BRIDGE_CARDBUS << 8, \
    .class_mask = ~0, \
    .driver_data = CARDBUS_TYPE_##type, \
    }

    and realise that you can't do the second if you include {} into
    PCI_DEVICE.

    --
    Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
    http://www.arm.linux.org.uk/personal/aboutme.html

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:47    [W:0.025 / U:60.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site