lkml.org 
[lkml]   [2003]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: C99 Initialisers
    On Wed, Aug 13, 2003 at 07:50:09PM +0200, Sam Ravnborg wrote:
    > On Wed, Aug 13, 2003 at 10:31:51AM -0700, Greg KH wrote:
    > >
    > > How about this patch? If you like it I'll add the pci.h change to the
    > > tree and let you take the tg3.c part.
    > >
    > > + { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5700) },
    > Why not without the extra {}'s so something like this:
    >
    > > + PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5701),
    > > + PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5702),
    > > { 0, }
    > > };
    > >
    > > +#define PCI_DEVICE(vend,dev) { \
    > > + .vendor = (vend), .device = (dev), \
    > > + .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID }

    No, you want to be able to add a ".driver_data = foo" after a
    PCI_DEVICE() macro. If you have the {} there, that prevents that from
    happening.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:47    [W:0.021 / U:1.740 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site