lkml.org 
[lkml]   [2003]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: new dev_t printable convention and lilo
Date


-----Original Message-----

>
> Andrey Borzenkov <arvidjaar@mail.ru> wrote:
> >
> > {pts/2}% cat /proc/cmdline
> > BOOT_IMAGE=260-t3smp2 ro root=345 devfs=mount
> >
> > I guess it has to use 03:45 now? Does it mean lilo has to be updated to handle
> > new convention?
> >
>
> I think we need to teach the parsing code to handle both styles.
>
> It's a bit of a screwup.
>

sorry for late reply.

I was wrong, the code that actually uses root= was unaffected.

It happens in name_to_dev_t:

if (strncmp(name, "/dev/", 5) != 0) {
res = (dev_t) simple_strtoul(name, &p, 16);
if (*p)
goto fail;
goto done;
}

it means handle-old-dev_t is meaningless and has to be removed ; and if we want people to use new format, it needs to go into name_to_dev_t.

sorry for confusion :(

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.119 / U:4.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site