[lkml]   [2003]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [linux-usb-devel] Re: [PATCH] oops in sd_shutdown
    Greg KH [] wrote:
    > On Tue, Aug 12, 2003 at 07:53:53AM +0100, Christoph Hellwig wrote:
    > > On Tue, Aug 12, 2003 at 12:28:44AM +0200, Andries Brouwer wrote:
    > > > I see an Oops in the SCSI code, caused by the fact that sdkp is NULL
    > > > in sd_shutdown. "How can that be?", you will ask - dev->driver_data was set
    > > > in sd_probe. But in my case sd_probe never finished. An insmod usb-storage
    > > > hangs forever, or at least for more than six hours, giving ample opportunity
    > > > to observe this race between sd_probe and sd_shutdown.
    > > > (Of course sd_probe hangs in sd_revalidate disk.)
    > >
    > > Well, this same problem could show upb in any other driver. Could
    > > you instead send a patch to Pat that the driver model never calls
    > > the shutdown method for a driver that hasn't finished ->probe?
    > I think it already will not do that due to taking the bus->subsys.rwsem
    > before calling either probe() or remove().

    Is the shutdown being called directly? The shutdown call is protected by
    a different rwsem. Depending on the call graph setting dev->driver on
    return of probe may provide a solution. I have not looked at all probe
    routines to understand if this would cause any bad side effects.

    Can you send the oops output?

    Michael Anderson

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:47    [W:0.020 / U:89.040 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site