[lkml]   [2003]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [linux-usb-devel] Re: [PATCH] oops in sd_shutdown
    On Mon, Aug 11, 2003 at 11:35:26PM -0700, Jeff Woods wrote:
    > At +0200 04:49 AM 8/12/2003, Andries Brouwer wrote:
    > >On Mon, Aug 11, 2003 at 06:13:50PM -0700, Jeff Woods wrote:
    > >
    > >>Looking only at the above code snippet, I'd suggest something more like:
    > >
    > >>+ if (!sdp ||
    > >
    > >This is not meaningful.
    > How is it not meaningful? The next action in the expression is to
    > dereference the pointer and if it has a NULL value then I expect the
    > dereference to fail. [But I am a complete newbie with respect to Linux
    > kernel and driver code so perhaps my understanding is in error. If so,
    > please enlighten me.]

    sdp can not be NULL in this case. That is why it is not meaningful to
    try to check for it.


    greg k-h
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:47    [W:0.031 / U:32.240 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site