lkml.org 
[lkml]   [2003]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.4.22-rc2 ext2 filesystem corruption


    On Tue, 12 Aug 2003, Martin Maney wrote:

    > On Tue, Aug 12, 2003 at 11:10:51AM -0300, Marcelo Tosatti wrote:
    > > I'll try to reproduce around here. In the meantime can you try to isolate
    > > the corruption. You said it didnt happen with 2.4.21 -- which pre shows up
    > > the problem?
    >
    > The problem appears only in rc2 (okay, assuming it's not a
    > regression). With 2.4.21-rc1 the file corruption I've been seeing does
    > not happen. From what Stephan has said I think I should try some more
    > varied tests. At this point I plan to do that a little later; I will
    > also try an rc2 with unnecessary features omitted from the build. So
    > far I've stayed with the base config, but it's a config shared by most
    > of the machines on the LAN and thus has plenty of extras.

    Well, rc2 had a Promise change. I'm not sure if it could be the cause, but
    lets check.

    Alan?

    Please try -rc2 with the following patch unpplied (patch -R):



    # This is a BitKeeper generated patch for the following project:
    # Project Name: Linux kernel tree
    # This patch format is intended for GNU patch command version 2.5 or higher.
    # This patch includes the following deltas:
    # ChangeSet 1.1070 -> 1.1071
    # drivers/ide/pci/pdc202xx_old.c 1.5 -> 1.6
    #
    # The following is the BitKeeper ChangeSet Log
    # --------------------------------------------
    # 03/08/08 alan@lxorguk.ukuu.org.uk 1.1071
    # [PATCH] PATCH: Promise cable
    #
    # The old driver used to check .id was NULL to detect drive absent
    # (which is wrong but generally worked) with the IDE changes it always
    # got it wrong. This fixes it to test .present instead.
    #
    # Without this fix it mistakenly assumes that the empty drive slot
    # cannot do UDMA66/100/133
    # --------------------------------------------
    #
    diff -Nru a/drivers/ide/pci/pdc202xx_old.c b/drivers/ide/pci/pdc202xx_old.c
    --- a/drivers/ide/pci/pdc202xx_old.c Tue Aug 12 14:08:21 2003
    +++ b/drivers/ide/pci/pdc202xx_old.c Tue Aug 12 14:08:21 2003
    @@ -423,9 +423,9 @@
    if (ultra_66) {
    /*
    * check to make sure drive on same channel
    - * is u66 capable
    + * is u66 capable. Ignore empty slots.
    */
    - if (hwif->drives[!(drive->dn%2)].id) {
    + if (hwif->drives[!(drive->dn%2)].present) {
    if (hwif->drives[!(drive->dn%2)].id->dma_ultra & 0x0078) {
    hwif->OUTB(CLKSPD | mask, (hwif->dma_master + 0x11));
    } else {
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:47    [W:0.040 / U:29.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site