lkml.org 
[lkml]   [2003]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Remove useless assertions from reiserfs
Dave Jones wrote:
> On Mon, Aug 11, 2003 at 01:45:30PM -0400, Jeff Garzik wrote:
> > Why are these useless?
>
> read the code not the diff.
>
> > >@@ -90,10 +90,6 @@ u32 keyed_hash(const signed char *msg, i
> > >
> > > if (len >= 12)
> > > {
> > >- //assert(len < 16);
> > >- if (len >= 16)
> > >- BUG();
> > >-
> > > a = (u32)msg[ 0] |
> > > (u32)msg[ 1] << 8 |
> > > (u32)msg[ 2] << 16|
> >
> > Seems like a valid check to me...
>
> Above this loop is another loop which we don't exit until len < 16

ok, agreed

Jeff




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.077 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site