Messages in this thread | | | Date | Wed, 9 Jul 2003 03:12:03 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] 1/5 VM changes: zone-pressure.patch |
| |
Nikita Danilov <Nikita@Namesys.COM> wrote: > > Add zone->pressure field. It estimates scanning intensity for this zone and > is calculated as exponentially decaying average of the scanning priority > required to free enough pages in this zone (mm/vmscan.c:zone_adj_pressure()). > > zone->pressure is supposed to be used in stead of scanning priority by > vmscan.c. This is used by later patches in a series. >
OK, fixes a bug.
> > diff -puN include/linux/mmzone.h~zone-pressure include/linux/mmzone.h > --- i386/include/linux/mmzone.h~zone-pressure Wed Jul 9 12:24:50 2003 > +++ i386-god/include/linux/mmzone.h Wed Jul 9 12:24:50 2003 > @@ -84,11 +84,23 @@ struct zone { > atomic_t refill_counter; > unsigned long nr_active; > unsigned long nr_inactive; > - int all_unreclaimable; /* All pages pinned */ > + int all_unreclaimable:1; /* All pages pinned */
I'll revert this change. Once we start adding bitfields in there they all need common locking and it gets messy. integers are simpler.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |