Messages in this thread | | | Date | Wed, 9 Jul 2003 20:56:11 -0700 | From | Greg KH <> | Subject | Re: [PATCH] timer clean up for i2c-keywest.c |
| |
On Wed, Jul 09, 2003 at 11:48:08AM +0200, Benjamin Herrenschmidt wrote: > On Tue, 2003-07-08 at 12:26, Benjamin Herrenschmidt wrote: > > On Mon, 2003-07-07 at 09:03, Paul Mackerras wrote: > > > This patch changes i2c-keywest.c to use mod_timer instead of a > > > two-line sequence to compute .expires and call add_timer in 3 places. > > > Without this patch I get a BUG from time to time in add_timer. > > > > Ok, here it is. It also remove the never used "polled" mode. The > > driver is now in sync with the more up-to-date 2.4 version ;) > > > > Sorry for not sending that earlier, I forgot about it and didn't > > notice it was out of sync. > > And just in case you didn't merge it yet... Here's a version changing > the timer->expire ; add_timer() pairs into calls to mod_timer, makes > the code slighly cleaner.
Thanks, I've applied this one.
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |