lkml.org 
[lkml]   [2003]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG?] do_generic_direct_write

On 06.28, J.A. Magallon wrote:
>
> On 06.27, Marcelo Tosatti wrote:
> >
> > Hello,
> >
> > Here goes -pre2 with a big number of changes, including the new aic7xxx
> > driver.
> >
> > I wont accept any big changes after -pre4: I want 2.4.22 timecycle to be
> > short.
> >
>
> Correct me if I'm wrong. I found this just by chance:
>
> mm/filemap.c:
> ssize_t
> do_generic_direct_write(struct file *file,const char *buf,size_t count, loff_t *ppos)
> ...
>
> if (!file->f_flags & O_DIRECT)
> BUG();
>
> This fails to trigger the BUG() just when it should. This should be:
>
> if (!(file->f_flags & O_DIRECT))
> BUG();

Someone can confirm this / flame me , plz ?

--
J.A. Magallon <jamagallon@able.es> \ Software is like sex:
werewolf.able.es \ It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.22-pre2-jam1 (gcc 3.3 (Mandrake Linux 9.2 3.3-2mdk))
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:46    [W:0.056 / U:0.016 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site