lkml.org 
[lkml]   [2003]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Inline vfat_strnicmp()
    On Thu, Jul 31, 2003 at 10:52:23PM +0900, OGAWA Hirofumi wrote:
    > Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> writes:
    >
    > > On 27 July 2003 19:33, OGAWA Hirofumi wrote:
    > > > Ren <l.s.r@web.de> writes:
    > > >
    > > > > the function vfat_strnicmp() has just one callsite. Inlining it
    > > > > actually shrinks vfat.o slightly.
    > > >
    > > > Thanks. I'll submit this patch to Linus.
    > >
    > > Just to deinline it in some months?
    > >
    > > Come on, automatically inlining static functions with
    > > just one callsite is a compiler's job. Don't do it.
    >
    > Unfortunately "gcc version 3.2.3 20030415 (Debian prerelease)"
    > doesn't, at least.

    And how big is the performance loss? Is it even measurable?
    And even if it is, is optimizing this really worth the trouble?


    Regards: David Weinehall
    --
    /) David Weinehall <tao@acc.umu.se> /) Northern lights wander (\
    // Maintainer of the v2.0 kernel // Dance across the winter sky //
    \) http://www.acc.umu.se/~tao/ (/ Full colour fire (/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:47    [W:0.020 / U:29.612 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site