lkml.org 
[lkml]   [2003]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH: Race in 2.6.0-test2 timer code
Andrea Arcangeli <andrea@suse.de> wrote:
>
> 2.6 will kernel crash like we did in 2.4 only if it calls
> add_timer_on from timer context (of course with a cpuid != than the
> smp_processor_id()), that would be fixed by the timer->lock everywhere
> that we've in 2.4 right now. (but there's no add_timer_on in 2.4
> anyways)

add_timer_on() was added specifically for slab bringup. If we need extra
locking to cope with it then the best solution would probably be to rename
it to add_timer_on_dont_use_this_for_anything_else().

But if we are going to rely on timer handlers only ever running on the
adding CPU for locking purposes then can we please have a big comment
somewhere describing what's going on? It's very subtle...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.095 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site