Messages in this thread | | | Date | Wed, 30 Jul 2003 16:28:43 -0700 | From | Greg KH <> | Subject | Re: PATCH : LEDs - possibly the most pointless kernel subsystem ever |
| |
On Tue, Jul 29, 2003 at 04:17:03PM +0100, Philip Graham Willoughby wrote: > Hi all, > > This patch adds an abstraction layer for programmable LED devices, > hardware drivers for the Status LEDs found on some Intel PIIX4E based > server hardware (notably the ISP1100 1U rackmount server) and LEDs wired > to the parallel port data lines.
Some minor comments: - read Documentation/CodingStyle and apply it to your code. - fix up the usages of the MOD_* functions. Get rid of the ones for the file_ops and have the core increment the count of the drivers before the core calls them. - please do not use ioctls. They are hell for 64bit kernels. Use either a filesystem for your subsystem, or sysfs. - try doing this for 2.6 first if you want any chance at all to get it into the main kernel trees.
Good luck,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |