lkml.org 
[lkml]   [2003]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Warn about taskfile?
Hi!

> > I had some strange fs corruption, and andi suggested that it probably
> > is TASKFILE-related. Perhaps this is good idea?
>
> Well without taskfile multimode may corrupt your disks, so pick one.
> This needs debugging not paranoia.

Can you explain a bit more? If multi_mode needs taskfile perhaps we
need to kill compilation? [Attached patch probably is not enough,
AFAICS multimode can be turned on without this config option, but it
should be clear what I mean.]

> > + It is safe to say Y to this question, but you should attach
> > + scratch monkey, first.
>
> "a scratch monkey" - also a lot of people won't get the reference

Okay, it is probably not the best help text ever.

If I want safest possible configuration for 2.6.0, is
CONFIG_TASKFILE_IO=n, CONFIG_IDEDISK_MULTI_MODE=n and hdparm -c 1
/dev/hda good idea?
Pavel

--- clean/drivers/ide/ide-disk.c 2003-07-27 22:31:13.000000000 +0200
+++ linux/drivers/ide/ide-disk.c 2003-07-31 00:59:36.000000000 +0200
@@ -1650,6 +1650,9 @@
drive->mult_count = 0;
if (id->max_multsect) {
#ifdef CONFIG_IDEDISK_MULTI_MODE
+#ifndef CONFIG_TASKFILE_IO
+#error IDEDISK_MULTI_MODE needs TASKFILE_IO for safe operation
+#endif
id->multsect = ((id->max_multsect/2) > 1) ? id->max_multsect : 0;
id->multsect_valid = id->multsect ? 1 : 0;
drive->mult_req = id->multsect_valid ? id->max_multsect : INITIAL_MULT_COUNT;

--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.093 / U:9.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site