lkml.org 
[lkml]   [2003]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: PATCH: console on by default if not embedded (save mucho pain)
Hi,

On Sun, 27 Jul 2003, Alan Cox wrote:

> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.6.0-test2/drivers/char/Kconfig linux-2.6.0-test2-ac1/drivers/char/Kconfig
> --- linux-2.6.0-test2/drivers/char/Kconfig 2003-07-10 21:04:38.000000000 +0100
> +++ linux-2.6.0-test2-ac1/drivers/char/Kconfig 2003-07-16 18:39:32.000000000 +0100
> @@ -5,8 +5,9 @@
> menu "Character devices"
>
> config VT
> - bool "Virtual terminal"
> + bool "Virtual terminal" if EMBEDDED
> requires INPUT=y
> + default y
> ---help---
> If you say Y here, you will get support for terminal devices with
> display and keyboard devices. These are called "virtual" because you

The patch below is better and this is one actually fixes most of the
upgrade pain, as the other options have reasonable defaults.
I'm not sure we should hide that much behind EMBEDDED, for people who just
want to load an old config and expect something workable the patch below
is enough, other people have to search for all the options hidden behind
EMBEDDED.

bye, Roman

Index: drivers/char/Kconfig
===================================================================
RCS file: /home/other/cvs/linux/linux-2.6/drivers/char/Kconfig,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Kconfig
--- drivers/char/Kconfig 14 Jul 2003 09:22:00 -0000 1.1.1.1
+++ drivers/char/Kconfig 22 Jul 2003 08:08:26 -0000
@@ -6,7 +6,7 @@ menu "Character devices"

config VT
bool "Virtual terminal"
- requires INPUT=y
+ select INPUT
---help---
If you say Y here, you will get support for terminal devices with
display and keyboard devices. These are called "virtual" because you
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.032 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site