lkml.org 
[lkml]   [2003]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH: fix 2 byte data leak due to padding
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> On Llu, 2003-07-28 at 04:49, Lou Langholtz wrote:
> > >+ memset(&tmp, 0, sizeof(struct __old_kernel_stat));
> > >
> > Wouldn't it be more clear (better) to use sizeof(tmp) here rather than
> > sizeof(struct _old_kernel_stat)?
>
> sizeof(variable) can be suprising some times so I always use sizeof(type) out
> of habit. (Think sizeof(x) when X later becomes a pointer)

#define memzero(addr) memset(addr, 0, sizeof(*addr))

would robustify a lot of these things...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.049 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site