lkml.org 
[lkml]   [2003]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c driver changes 2.6.0-test1
On Wed, Jul 23, 2003 at 02:43:55PM -0300, Marcelo Penna Guerra wrote:
> Hi,
>
> This code doesn't work well. I was porting this code to 2.5 myself, so I did
> some fixes to the code in 2.6.0-test1-ac3.
>
> On Saturday 19 July 2003 12:54, Greg KH wrote:
>
> > + smbus->adapter.algo_data = smbus;
> > +*/
>
> The problem is here. If you leave this line commented out, you'll have
> problems when inserting the chip module.
>
> > smbus->adapter = nforce2_adapter;
>
> Also, I don't see the point in commenting out all this lines just to introduce
> a nforce2_adapter struct. If this is the correct aprouch, just remove the
> duplicate code instead of just commenting it out.
>
> Attached is a patch to fix this problems. I can't test it very well as I can
> only see the sensors in my board with i2c-isa, but everything loads fine.
> This patch also moves the PCI ids to the pci_ids.h file.

I'd like to see someone who has this hardware test these changes before
taking them.

Anyone want to verify that things still work properly with this patch?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.122 / U:1.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site