lkml.org 
[lkml]   [2003]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Port SquashFS to 2.6
    From
    Date
    On Sat, 2003-07-19 at 18:59, junkio@cox.net wrote:

    > +static int squashfs_symlink_readpage(struct file *file, struct page *page)
    > +{
    > + struct inode *inode = page->mapping->host;
    > + struct squashfs_inode_info *sqi = SQUASH_I(inode);
    > + int index = page->index << PAGE_CACHE_SHIFT, length = 0, bytes;
    > + int block = sqi->start_block;
    > + int offset = sqi->offset;
    > +
    > + TRACE("Entered squashfs_symlink_readpage, page index %d, start block %x, offset %x\n",
    > + page->index, sqi->start_block, sqi->offset);
    > +
    > + while(length < index) {
    > + char buffer[PAGE_CACHE_SIZE];

    Hmm, isn't that 4K allocated on the stack? Ouch.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:47    [W:0.062 / U:62.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site