Messages in this thread | | | Date | Fri, 18 Jul 2003 08:24:42 +0200 | From | Michael Hunold <> | Subject | Re: [PATCH 1/1] Add two drivers for USB based DVB-T adapters |
| |
Hello Greg,
>>+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0) >>+static void *ttusb_probe(struct usb_device *udev, unsigned int ifnum, >>+ const struct usb_device_id *id) >>+{
> Ick, you don't really want to try to support all of the USB changes in > the same driver, now do you? Why not just live with two different > drivers.
Because I'm the poor guy that has to test it with 2.4 and 2.5 and who's submitting the patches. 8-)
The author is mainly working with 2.4, I'm trying to compile it and test it for 2.5.
> The ALSA people eventually gave up trying to do this... :)
I agree, I'll separate the stuff now that it has gone into Linus' tree.
>>+#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,69)) >>+#undef devfs_remove >>+#define devfs_remove(x) devfs_unregister(ttusb->stc_devfs_handle); >>+#endif >>+#if 0 >>+ devfs_remove(TTUSB_BUDGET_NAME); >>+#endif
> You end up with crud like this because of trying to support old kernels. > Why do you care about kernels prior to 2.5.69? If so, your USB kernel > checks are wrong, as 2.5.0 didn't have those API changes :)
I already wrote Linus that I'll remove this compatibility crap with the next patchset.
> thanks, > greg k-h
Thanks for your feedback!
CU Michael.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |