Messages in this thread | | | Date | Tue, 15 Jul 2003 19:38:44 +0200 | From | Dominik Brodowski <> | Subject | Re: Linux v2.6.0-test1 |
| |
On Tue, Jul 15, 2003 at 11:56:57AM +0100, Dave Jones wrote: > On Tue, Jul 15, 2003 at 12:11:32AM -0400, Matt Reppert wrote: > > I need this to build on powerpc (plus the patch by Jasper Spaans already posted). > > > * cpufreq_parse_policy - parse a policy string > > diff -NruX /home/arashi/kdontdiff linux-2.6.0-test1-orig/include/linux/notifier.h linux-2.6.0-test1/include/linux/notifier.h > > --- linux-2.6.0-test1-orig/include/linux/notifier.h 2003-07-13 23:30:36.000000000 -0400 > > +++ linux-2.6.0-test1/include/linux/notifier.h 2003-07-14 23:41:56.000000000 -0400 > > @@ -65,6 +65,7 @@ > > #define CPU_UP_CANCELED 0x0004 /* CPU (unsigned)v NOT coming up */ > > #define CPU_OFFLINE 0x0005 /* CPU (unsigned)v offline (still scheduling) */ > > #define CPU_DEAD 0x0006 /* CPU (unsigned)v dead */ > > +#define CPUFREQ_ALL_CPUS ((NR_CPUS)) > > > > #endif /* __KERNEL__ */ > > #endif /* _LINUX_NOTIFIER_H */ > > include/linux/cpufreq.h seems a more natural place to put this. > Can you confirm that works ok on PPC? I lack hardware to test.
No, please don't do this. There is no function at all in the cpufreq core which may be called with CPUFREQ_ALL_CPUS as arguments. Well, there had been, many months ago. But it really shall not be defined or used anywhere outside the 2.4. proc-intf any more.
Now, wrt the ppc-cpufreq driver: benh's 2.5. tree includes a much more updated version than plain 2.6.0-test1 -- Ben, can you push that to Linus, please? Also, please change the line freqs.cpu = CPUFREQ_ALL_CPUS; in do_set_cpu_speed() to freqs.cpu = 0; which is the way it should be done now.
Dominik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |