Messages in this thread Patch in this message | | | Date | Fri, 11 Jul 2003 19:11:14 +0100 | From | Alan Cox <> | Subject | PATCH: Fix security leaks in btaudio |
| |
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.5.75/sound/oss/btaudio.c linux-2.5.75-ac1/sound/oss/btaudio.c --- linux-2.5.75/sound/oss/btaudio.c 2003-07-10 21:06:05.000000000 +0100 +++ linux-2.5.75-ac1/sound/oss/btaudio.c 2003-07-11 16:28:57.000000000 +0100 @@ -328,8 +328,8 @@ if (cmd == SOUND_MIXER_INFO) { mixer_info info; memset(&info,0,sizeof(info)); - strlcpy(info.id,"bt878",sizeof(info.id)); - strlcpy(info.name,"Brooktree Bt878 audio",sizeof(info.name)); + strncpy(info.id,"bt878",sizeof(info.id)); + strncpy(info.name,"Brooktree Bt878 audio",sizeof(info.name)); info.modify_counter = bta->mixcount; if (copy_to_user((void *)arg, &info, sizeof(info))) return -EFAULT; @@ -338,8 +338,8 @@ if (cmd == SOUND_OLD_MIXER_INFO) { _old_mixer_info info; memset(&info,0,sizeof(info)); - strlcpy(info.id,"bt878",sizeof(info.id)-1); - strlcpy(info.name,"Brooktree Bt878 audio",sizeof(info.name)); + strncpy(info.id,"bt878",sizeof(info.id)-1); + strncpy(info.name,"Brooktree Bt878 audio",sizeof(info.name)); if (copy_to_user((void *)arg, &info, sizeof(info))) return -EFAULT; return 0; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |