lkml.org 
[lkml]   [2003]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] add seq file helpers from 2.5 (fwd)
    * Marcelo Tosatti (marcelo@conectiva.com.br) wrote:
    > +int single_open(struct file *file, int (*show)(struct seq_file *, void*), void *data)
    > +{
    > + struct seq_operations *op = kmalloc(sizeof(*op), GFP_KERNEL);
    > + int res = -ENOMEM;
    > +
    > + if (op) {
    > + op->start = single_start;
    > + op->next = single_next;
    > + op->stop = single_stop;
    > + op->show = show;
    > + res = seq_open(file, op);

    Any reason not to simply allocate static ops struct? As in:

    static struct seq_operations single_ops = {
    .start = single_start;
    .next = single_next;
    .stop = single_stop;
    .show = show;
    };

    int single_open()
    {
    req = seq_open(file, &single_ops);
    ...
    }

    thanks,
    -chris
    --
    Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:46    [W:0.036 / U:0.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site