lkml.org 
[lkml]   [2003]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PCI: remove usage of pci_for_each_dev() in sound/oss/via82cxxx_audio.c
On Thu, Jun 05, 2003 at 12:18:50AM -0400, Jeff Garzik wrote:
> Linux Kernel Mailing List wrote:
> >ChangeSet 1.1254.4.15, 2003/06/04 12:30:25-07:00, greg@kroah.com
> >
> > [PATCH] PCI: remove usage of pci_for_each_dev() in
> > sound/oss/via82cxxx_audio.c
> >
> >
> ># This patch includes the following deltas:
> ># ChangeSet 1.1254.4.14 -> 1.1254.4.15
> ># sound/oss/via82cxxx_audio.c 1.27 -> 1.28
> >#
> >
> > via82cxxx_audio.c | 11 +++++------
> > 1 files changed, 5 insertions(+), 6 deletions(-)
> >
> >
> >diff -Nru a/sound/oss/via82cxxx_audio.c b/sound/oss/via82cxxx_audio.c
> >--- a/sound/oss/via82cxxx_audio.c Wed Jun 4 20:28:51 2003
> >+++ b/sound/oss/via82cxxx_audio.c Wed Jun 4 20:28:51 2003
> >@@ -1357,12 +1357,12 @@
> > {
> > int minor = minor(inode->i_rdev);
> > struct via_info *card;
> >- struct pci_dev *pdev;
> >+ struct pci_dev *pdev = NULL;
> > struct pci_driver *drvr;
> >
> > DPRINTK ("ENTER\n");
> >
> >- pci_for_each_dev(pdev) {
> >+ while ((pdev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) !=
> >NULL) {
> > drvr = pci_dev_driver (pdev);
> > if (drvr == &via_driver) {
> > assert (pci_get_drvdata (pdev) != NULL);
>
>
> Looking at your various commits in this vein, it really looks like there
> needs to be a function that returns the PCI device, given the struct
> pci_driver pointer. pci_find_driver() perhaps?

Hm, only about 3 places really use that, and they would want something
that would iterate over all pci devices that were bound to that driver.
As the three places are in OSS drivers, I don't know if it's really
worth adding a pci core function for them :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.032 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site