Messages in this thread | | | Date | Thu, 5 Jun 2003 10:18:35 -0700 | From | Greg KH <> | Subject | Re: [BK PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70 |
| |
On Thu, Jun 05, 2003 at 10:18:02AM +0100, Dave Jones wrote: > > The fact that a tree-wide 'cleanup' like this goes in just a few hours > after its posted before chance to comment is another argument, but > concentrating on the technical point here, I still think this is a > step backwards.
Why? I just got rid of a function (well macro) that isn't even needed (as proven by replacing it with an existing function.) That's technically a good thing :)
Now I can agree that some of those replacements could be done with a different function call, as almost none of the replacements in the driver/* tree really want to walk all of the pci devices in the tree. They usually just want to walk all devices of a type of pci device (be it capability, or other trait.) I'd be glad to take changes of this sort in the future.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |