lkml.org 
[lkml]   [2003]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] fix for kallsyms module symbol resolution problem
Date
In message <1056942790.10904.324.camel@mulgrave> you write:
> On Sun, 2003-06-29 at 21:06, Rusty Russell wrote:
> > Please test, because that's only one problem.
> >
> > The other is that the module_text_address() returns true if the value
> > is within the module, *not* just if it's within a function. So you
> > can get some noise there, too, on archs which don't do real
> > backtracing.
>
> Well, the fix is pretty cast iron in that it will print out the closest
> symbol with a non null name (which has got to be better than printing an
> empty string). The routine length may still be wrong since the next
> closest symbol may still be null.

Yeah, but I was trying to get you to do more work. And if the names
resulting are useless anyway, why apply the patch?

> Perhaps there should be a per-arch hook for purging the symbol tables of
> irrelevant symbols before we do kallsyms lookups in it?

I think you can do it easily in module_finalize... or if we were
ambitious we'd extract only the function symbols rather than keeping
the whole strtab and symtab.

Cheers!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:46    [from the cache]
©2003-2011 Jasper Spaans