lkml.org 
[lkml]   [2003]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[CHECKER][PATCH] bw-qcam.c bad copy_to_user
From
Like radio-cadet.c, bw-qcam.c is calling copy_to_user() where it 
shouldn't. The user buffer is copied to/from kernel space by
drivers/media/video/videodev.c:video_usercopy() . Please apply.

--
Hollis Blanchard
IBM Linux Technology Center
===== drivers/media/video/bw-qcam.c 1.11 vs edited =====
--- 1.11/drivers/media/video/bw-qcam.c Sun Feb 16 18:16:53 2003
+++ edited/drivers/media/video/bw-qcam.c Tue Jun 3 10:28:29 2003
@@ -723,8 +723,6 @@
/* Good question.. its composite or SVHS so.. */
v->type = VIDEO_TYPE_CAMERA;
strcpy(v->name, "Camera");
- if(copy_to_user(arg, &v, sizeof(v)))
- return -EFAULT;
return 0;
}
case VIDIOCSCHAN:
\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.018 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site