lkml.org 
[lkml]   [2003]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [2.5 patch] remove two unused variables from mxser.c
Date
In message <20030628023935.GQ24661@fs.tum.de> you write:
> On Fri, Jun 20, 2003 at 02:31:06PM +1000, Rusty Russell wrote:
> > In message <20030619231222.GF29247@fs.tum.de> you write:
> > > The patch below removes two unused variables from drivers/char/mxser.c .
> >
> > While you're there, would you fix the init returning "-1" for no good
> > reason at the bottom, too? (I don't think they really meant EPERM).
>
> There is at least one other driver under drivers/char/ doing the
> same...
>
> Which return code do you suggest?

Looking at the code, there are other problems.

The last thing to fail (which triggers this -1 return) is
tty_register_driver(mxvar_sdriver): so keep that return code and use
it.

But they do put_tty_driver(mxvar_sdriver) in the failure path, which
seems wrong, too...

Good luck!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:46    [W:0.121 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site