[lkml]   [2003]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC][PATCH] nbd driver for 2.5.72

> The following (attached) patch to the network block device driver (nbd)
> is now specific to just 2.5.72 with various other changes as suggested
> by Pavel and Steven. Please let me know what you think. There's
> definately room for more improvements but I don't believe the existing
> 2.5 series nbd driver (at least up through 2.5.72) works at all. Has
> anyone tested nbd as distributed with 2.5? I've been too busy writing
> this new nbd driver to even have checked the original driver (but some
> of the bugs I've encountered make me believe the original won't work at
> all). Here's a URL to follow to see just the two resultant files (and/or
> the patch in case it doesn't come through as an attachment):
> <>.
> Thanks!
> PS: Please email me or CC me if you have any feedback for me.

> diff -urN linux-2.5.72/drivers/block/nbd.c linux-2.5.72-new/drivers/block/nbd.c
> --- linux-2.5.72/drivers/block/nbd.c 2003-06-16 22:19:44.000000000 -0600
> +++ linux-2.5.72-new/drivers/block/nbd.c 2003-06-20 21:27:44.650037153 -0600
> @@ -24,10 +25,35 @@
> * 01-3-11 Make nbd work with new Linux block layer code. It now supports
> * plugging like all the other block devices. Also added in MSG_MORE to
> * reduce number of partial TCP segments sent. <>
> - * 01-12-6 Fix deadlock condition by making queue locks independent of
> + * 01-12-6 Fix deadlock condition by making queue locks independant

This actually *introduces* typo.

> #include <asm/uaccess.h>
> #include <asm/types.h>
> +#include <asm/system.h> /* for __xchg()... */
> +#define atomic_exchange(x,ptr,size) __xchg((x),(ptr),(size))

atomic_exchange seems to be defined but never used?

When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:36    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean