lkml.org 
[lkml]   [2003]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.4.21 Floppy Fallback with NFS root ...
On Tue, Jun 17, 2003 at 05:11:14PM +0200, Pavel Machek wrote:
> Hi!
>
> > I'm curious, is it intentional that, if you select
> > NFS support and NFS Root support, that the fact, that
> > no nfs is available, or selected via boot options,
> > automatically leads to a floppy boot?
> >
> > I would suggest the following trivial patch, to give
> > the kernel compiler a chance to disable this 'feature'.
> >
> > please correct me if I'm talking nonsense ...
>
> This might be okay for 2.5.X, but its definitely bad idea for
> 2.4.X. (User visible change without good reason).

okay, first the good reason :)

currently it is not possible to compile a kernel with
root NFS support, which in case of NFS failure, (or
missing NFS/network options) boots from HD, instead
it asks you to insert a Floppy ...

and now ad 'user visible change' ...

what if I make it CONFIG_NOFLOPPY_FALLBACK and
change the #ifdef to #ifndef ? This would give
the same (strange?) behaviour as now, but an option
to disable the fallback (to floppy) ...

please comment,
Herbert

> > diff -NurbP --minimal linux-2.4.21/fs/Config.in linux-2.4.21-ffb/fs/Config.in
> > --- linux-2.4.21/fs/Config.in Tue Dec 10 03:25:19 2002
> > +++ linux-2.4.21-ffb/fs/Config.in Mon Jun 16 15:05:09 2003
> > @@ -103,6 +103,7 @@
> > dep_tristate 'NFS file system support' CONFIG_NFS_FS $CONFIG_INET
> > dep_mbool ' Provide NFSv3 client support' CONFIG_NFS_V3 $CONFIG_NFS_FS
> > dep_bool ' Root file system on NFS' CONFIG_ROOT_NFS $CONFIG_NFS_FS $CONFIG_IP_PNP
> > + dep_bool ' Floppy Fallback' CONFIG_FLOPPY_FALLBACK $CONFIG_ROOT_NFS
> >
> > dep_tristate 'NFS server support' CONFIG_NFSD $CONFIG_INET
> > dep_mbool ' Provide NFSv3 server support' CONFIG_NFSD_V3 $CONFIG_NFSD
> > diff -NurbP --minimal linux-2.4.21/init/do_mounts.c linux-2.4.21-ffb/init/do_mounts.c
> > --- linux-2.4.21/init/do_mounts.c Fri Jun 13 17:49:28 2003
> > +++ linux-2.4.21-ffb/init/do_mounts.c Mon Jun 16 15:00:23 2003
> > @@ -754,8 +754,10 @@
> > printk("VFS: Mounted root (nfs filesystem).\n");
> > return;
> > }
> > +# ifdef CONFIG_FLOPPY_FALLBACK
> > printk(KERN_ERR "VFS: Unable to mount root fs via NFS, trying floppy.\n");
> > ROOT_DEV = MKDEV(FLOPPY_MAJOR, 0);
> > +# endif
> > }
> > #endif
> > devfs_make_root(root_device_name);
> >
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
> --
> When do you have a heart between your knees?
> [Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.086 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site