lkml.org 
[lkml]   [2003]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] use tty_driver.name as default .devfs_name
  Hi,

In 2.5.71 with devfs enabled my USB modem appears as /dev/<NULL>0
instead of the usual /dev/usb/acm/0. I tracked down this problem to be
due to

ChangeSet@1.1215.98.11 2003-06-06 08:54:35-07:00 akpm@digeo.com

(originally "[PATCH] Fix tty devfs mess" from Christoph Hellwig
<hch@lst.de>)

where a new .devfs_name field was introduced in struct tty_driver.
However, many drivers (including cdc-acm) haven't been updated to define
it. OTOH they seem to be quite happy using their .name for devfs as
well. This patch makes .name the default .devfs_name. Since
tty_{,un}register_device() appear to be the only users of .devfs_name,
there should be no side effects. WFM. Please consider applying.

Roman.


--- linux-2.5.71/drivers/char/tty_io.c~ 2003-06-14 23:18:23.000000000 +0400
+++ linux-2.5.71/drivers/char/tty_io.c 2003-06-15 22:20:51.000000000 +0400
@@ -2183,6 +2183,10 @@
return;
}

+ /* Use driver name for devfs as well */
+ if (!driver->devfs_name)
+ driver->devfs_name = driver->name;
+
devfs_mk_cdev(dev, S_IFCHR | S_IRUSR | S_IWUSR,
"%s%d", driver->devfs_name, index + driver->name_base);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.015 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site