lkml.org 
[lkml]   [2003]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] make cramfs look less hostile
On Sun, 15 June 2003 12:46:26 -0400, Mark Hahn wrote:
>
> > This thing has been biting me now and again. "cramfs: wrong magic\n"
> > looks like an error condition to most people and thus creates bug
> > reports. But there is no bug per se in having cramfs support in the
> > kernel and booting from a jffs2 rootfs. So instead of teaching the
> > users over and over, how about this little one-liner?
>
> good argument. but I was expecting you to remove the message entirely,
> or else make it *really* explanatory like "OK, not cramfs then"

Well, some embedded people trying to get this shiny new hardware with
bad debugging interfaces up and running might still like that printk.
But it would make sense to wrap it behind CONFIG_CRAMFS_DEBUG or
#define DEBUG 1 inside inode.c

Comments?

Jörn

--
Optimizations always bust things, because all optimizations are, in
the long haul, a form of cheating, and cheaters eventually get caught.
-- Larry Wall
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.043 / U:9.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site