lkml.org 
[lkml]   [2003]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Consolidate binfmt choices in Kconfig
On Thu, Jun 12, 2003 at 06:20:11PM +0100, Matthew Wilcox wrote:

> The full patch is around 60k, and is available from
> http://ftp.linux.org.uk/pub/linux/willy/patches/binfmt-Kconfig.diff
>
> 21 files changed, 117 insertions(+), 922 deletions(-)
>
> It's very repetitive, so to give a flavour for it, here's i386, m68knommu
> and fs/Kconfig.binfmt. I rewrote the BINFMT_AOUT helptext to bring it
> into this decade.
>
> Comments welcomed; I'll send it to Linus tomorrow if I don't hear anything.

Just a nit:

> Index: fs/Kconfig.binfmt
> ===================================================================
[snip]
> +config BINFMT_FLAT
> + tristate "Kernel support for flat binaries"
> + depends on !MMU
> + help
> + Support uClinux FLAT format binaries.
> +
> +config BINFMT_ZFLAT
> + bool " Enable ZFLAT support"
> + depends on BINFMT_FLAT
> + help
> + Support FLAT format compressed binaries

Shouldn't that just be:
bool "Enable ZFLAT support"
as the config bits take care of indentation now?

--
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.027 / U:1.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site