lkml.org 
[lkml]   [2003]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.5.70-bk16: nfs crash
On Thu, Jun 12, 2003 at 07:22:54PM +0530, Dipankar Sarma wrote:
> I am not supprised at all by this, I can see two csets in Linus' tree
> that will definitely break dcache -
>
> 1. http://linux.bkbits.net:8080/linux-2.5/cset@1.1215.104.2?nav=index.html|ChangeSet@-2d
>
> __d_drop() *must not* initialize d_hash fields. Lockfree lookup depends on
> that. If __d_drop() needs to be allowed on an unhashed dentry, the right
> thing to do would be to check for DCACHE_UNHASHED before unhashing. I will
> submit a patch a little later to do this.
>
>
> 2. http://linux.bkbits.net:8080/linux-2.5/cset@1.1215.104.1?nav=index.html|ChangeSet@-2d
>
> hlist poison patch is broken. list_del_rcu() and hlist_del_rcu()
> *must not* re-initialize the pointers. Maneesh submitted a patch
> earlier today that corrects this -
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=105541206017154&w=2

John,

Can you try the patch below along with Maneesh's patch mentioned
above to see if they fix your problem ?

Thanks
Dipankar



Fix __d_drop() to be allowed on unhashed dentries correctly. Don't
re-initialize the pointers, instead check for DCACHE_UNHASHED
before really unhashing it.


include/linux/dcache.h | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)

diff -puN include/linux/dcache.h~dentry-hash-init-fix include/linux/dcache.h
--- linux-2.5.70-bk16/include/linux/dcache.h~dentry-hash-init-fix 2003-06-12 20:43:32.000000000 +0530
+++ linux-2.5.70-bk16-dipankar/include/linux/dcache.h 2003-06-12 20:47:10.000000000 +0530
@@ -174,8 +174,10 @@ extern spinlock_t dcache_lock;

static inline void __d_drop(struct dentry *dentry)
{
- dentry->d_vfs_flags |= DCACHE_UNHASHED;
- hlist_del_rcu_init(&dentry->d_hash);
+ if (!(dentry->d_vfs_flags & DCACHE_UNHASHED)) {
+ dentry->d_vfs_flags |= DCACHE_UNHASHED;
+ hlist_del_rcu(&dentry->d_hash);
+ }
}

static inline void d_drop(struct dentry *dentry)
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.051 / U:4.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site