lkml.org 
[lkml]   [2003]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] And yet more PCI fixes for 2.5.70
From
Date
On Mer, 2003-06-11 at 18:46, Jeff Garzik wrote:
> Its an API that doesn't make sense.

Is this a PCI box is a sane thing to ask

> "Is a PCI bus present?" Further, the IDE code calculating system
> bus speed it should really be calling a PCI callback, not asking "Do
> I have a PCI bus?" and making a guess... a guess which seems wrong
> in several cases, including my Dual Athlon box w/ 100% 66 Mhz PCI bus.

Wrong. You misunderstand why this is done. We want to know for various
wackomtic old IDE devices and the key to knowing if its going to be
33Mhz is "does it have a PCI bus".

BTW if you want to be pedantic your "fix" is as broken as the original
since PCI root bridges can live on hotpluggable cards on a different
system bus 8)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.067 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site