lkml.org 
[lkml]   [2003]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectFw: [PATCH] cleanup up seq file usage in resource.c


Date: Wed, 28 May 2003 20:05:33 -0400
From: Jeff Muizelaar <muizelaar@rogers.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] cleanup up seq file usage in resource.c


This patch against 2.5.70-bk2 removes the buffer allocation from
resource.c and lets seq_read do it instead.

-Jeff
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Looks fine to me and works too.

Andrew, please apply to your next patch set.

Thanks,
--
~Randy
diff -urN linux-2.5.70-bk2/kernel/resource.c linux-2.5.70-bk2-resource-seq-file-cleanup/kernel/resource.c
--- linux-2.5.70-bk2/kernel/resource.c 2003-05-26 21:00:42.000000000 -0400
+++ linux-2.5.70-bk2-resource-seq-file-cleanup/kernel/resource.c 2003-05-28 19:22:04.000000000 -0400
@@ -71,20 +71,7 @@

static int ioresources_open(struct file *file, struct resource *root)
{
- char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
- struct seq_file *m;
- int res;
-
- if (!buf)
- return -ENOMEM;
- res = single_open(file, ioresources_show, root);
- if (!res) {
- m = file->private_data;
- m->buf = buf;
- m->size = PAGE_SIZE;
- } else
- kfree(buf);
- return res;
+ return single_open(file, ioresources_show, root);
}

static int ioports_open(struct inode *inode, struct file *file)
\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.023 / U:8.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site